Repository navigation
Preserve Gateway validation details for missing schema ID - #39
Merged
hanyfakhry merged 2 commits intoOct 28, 2026
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The updated failure test always supplies a non-empty detail, leaving the new errors fallback untested, with multiple-entry, correlation-ID, and trace-only coverage still needed.
1 open issue
What changed in this PR
This PR preserves Gateway validation details when dataset import fails because a schema ID is missing, while retaining the correlation ID for troubleshooting.
Changes:
- Include response
detail, or field-levelerrorsas a fallback, in import exceptions. - Update Gateway tests to check validation details and the correlation ID.
- Verify that DataCatalogue preserves the validation message when triggering rollback.
| File | Description |
|---|---|
| tests/test_gateway.py | Checks missing-schema validation details in import exceptions. |
| tests/test_datacatalogue.py | Checks validation-message preservation during rollback. |
| src/dataworkbench/gateway.py | Extracts validation details and includes them alongside the correlation ID. |
Review effort: Balanced
Co-authored-by: micsoko <175594233+micsoko@users.noreply.github.com>
hanyfakhry
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.